test(refactor): clean up run_in_subprocess#762
Merged
cpcloud merged 3 commits intoNVIDIA:mainfrom Jan 30, 2026
Merged
Conversation
Contributor
Author
|
/ok to test |
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Greptile OverviewGreptile SummaryThis PR successfully refactors Key changes:
The refactoring is clean and maintains backward compatibility with all existing callers of Confidence Score: 5/5
Important Files Changed
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Author
|
/ok to test |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Contributor
Author
|
/ok to test |
kkraus14
approved these changes
Jan 30, 2026
gmarkall
added a commit
to gmarkall/numba-cuda
that referenced
this pull request
Feb 5, 2026
- Add CUDA FP8 type + conversion bindings (E5M2/E4M3/E8M0), HW-accel detection, and comprehensive tests (NVIDIA#686) - fix: fix boolean return type mismatch in C ABI wrapper (NVIDIA#770) - Remove unused `rtapi.py` (NVIDIA#773) - feat: Add documentation for debugging Numba CUDA programs with CUDA GDB and VSCode (NVIDIA#665) - Move `CallConv` from `CUDAContext` to `FunctionDescriptor` (NVIDIA#717) - Generate line info for PHI exporters in terminator block (NVIDIA#756) - Add `cuda-core` to `oldest` tests (NVIDIA#769) - build(deps): bump actions/setup-python from 6.1.0 to 6.2.0 in the actions-monthly group across 1 directory (NVIDIA#768) - Enable apt proxy caching; skip hosted Windows builds (NVIDIA#766) - Disable automatic review trigger for Greptile (NVIDIA#743) - test(refactor): clean up `run_in_subprocess` (NVIDIA#762) - remove super args (NVIDIA#763)
Merged
kkraus14
pushed a commit
that referenced
this pull request
Feb 5, 2026
- Add CUDA FP8 type + conversion bindings (E5M2/E4M3/E8M0), HW-accel detection, and comprehensive tests (#686) - fix: fix boolean return type mismatch in C ABI wrapper (#770) - Remove unused `rtapi.py` (#773) - feat: Add documentation for debugging Numba CUDA programs with CUDA GDB and VSCode (#665) - Move `CallConv` from `CUDAContext` to `FunctionDescriptor` (#717) - Generate line info for PHI exporters in terminator block (#756) - Add `cuda-core` to `oldest` tests (#769) - build(deps): bump actions/setup-python from 6.1.0 to 6.2.0 in the actions-monthly group across 1 directory (#768) - Enable apt proxy caching; skip hosted Windows builds (#766) - Disable automatic review trigger for Greptile (#743) - test(refactor): clean up `run_in_subprocess` (#762) - remove super args (#763)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small PR to refactor
run_in_subprocessto avoid explicit and overly verbosePopenuse.